Eliminating C/C++ implicit conversions #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amaras
added
Implementation Edit
ShadowMitia
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove all implicit conversions in both the C and C++ codes we have.
Each file change was put in its own commit for easier revertability.
Most changes were mainly following the compiler instructions, athough a few codes needed a change of types in their structure (looking at Huffman encoding in C).
I can confirm each code compiles correctly on my machine, with the Conversion error in place.
If you have trouble with compilation on Windows because of the change, please put it below and we'll see what we can do.
There should not be a problem on Linux, though.